Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asar option doesn't put anything in app.asar #85

Closed
rahatarmanahmed opened this issue Jun 27, 2015 · 2 comments
Closed

asar option doesn't put anything in app.asar #85

rahatarmanahmed opened this issue Jun 27, 2015 · 2 comments

Comments

@rahatarmanahmed
Copy link
Contributor

Running Windows x64
Building win32-x64
electron-packager v4.1.3
Options:

// My script handles arguments, but I tested with the following values.
var platform = 'win32';
var arch =  'x64'
var packagerOpts = {
    dir: __dirname + '/..',
    name: 'Squelch-' + platform + '-' + arch,
    asar: true,
    version: pkg.devDependencies['electron-prebuilt'].match(/\d+\.\d+\.\d/)[0],
    platform: platform,
    arch: arch,
    out: __dirname + '/../release',
    prune: true,
    ignore: [
    '/test($|/)',
    '/tools($|/)',
    '/scripts($|/)',
    '/release($|/)',
    ]
};
packager(packagerOpts, function(err, path) {
    if(err) { throw err; }
    console.log('Successfully built package at ' + path);
});

The build completes without errors, but my app.asar seems to be empty. I can run asar list resources/resources/app.asar and it won't output anything. My app code is there in resources/app, and removing that makes the app open the default_app instead, so it's definitely not loading from app.asar.

...Actually, why is my app code there as a folder? Either the asar option doesn't work right or that just ruins the point of asar.

@kfranqueiro
Copy link
Contributor

This sounds like #81 and #73 which have been resolved on master (but not in a release yet).

Edit: now available in 4.2.0.

@kfranqueiro
Copy link
Contributor

I believe this is fixed in 4.2.0 and 5.0.0 so I'm closing this. Let us know if you still experience this issue after updating. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants