Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support custom fs #10

Merged
merged 2 commits into from
May 16, 2017
Merged

support custom fs #10

merged 2 commits into from
May 16, 2017

Conversation

joehand
Copy link
Collaborator

@joehand joehand commented Apr 20, 2017

Adds support for custom fs. Does not break current API.

var db = toiletdb({name: 'file.json', fs: archive})

// db.write etc

I wasn't sure about if we wanted to include the writing of a temporary file for the custom fs. For example, it doesn't seem like in hyperdrive we'd want to write a temporary file. Thoughts?

@joehand
Copy link
Collaborator Author

joehand commented May 16, 2017

I wasn't sure about if we wanted to include the writing of a temporary file for the custom fs. For example, it doesn't seem like in hyperdrive we'd want to write a temporary file. Thoughts?

Made it to not write temp files for a custom fs. We can add this as an option later.

@joehand joehand merged commit a03b0a0 into max-mapper:master May 16, 2017
@joehand joehand deleted the custom-fs branch May 16, 2017 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant