Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [2.3-SNAPSHOT] Field/Method duplicate when remapping #17

Closed
XiaoPangxie732 opened this issue Jun 21, 2021 · 0 comments
Closed

[BUG] [2.3-SNAPSHOT] Field/Method duplicate when remapping #17

XiaoPangxie732 opened this issue Jun 21, 2021 · 0 comments
Assignees
@XiaoPangxie732
Labels
bug Something isn't working
Projects
Current Progress

Comments

@XiaoPangxie732
Copy link
Member

XiaoPangxie732 commented Jun 21, 2021 •
edited

Describe the bug
Field duplicate when remapping

To Reproduce
Steps to reproduce the behavior:

  1. Run MCD
  2. See error

Expected behavior
Run successfully

System Info:

  • OS: Windows 10
  • Arch: x64
  • Java: AdoptOpenJDK HotSpot 16.0.1+9
  • MinecraftDecompiler Version 2.3-SNAPSHOT

Additional context
This is because when processing fields in super classes, SC1 class has an inaccessible field, SC2 class has an accessible field. They may have the same obfuscated name. But MinecraftDecompiler doesn't know how to choose because it can't get the field's access flags when deobfuscating.
@XiaoPangxie732 XiaoPangxie732 added the bug Something isn't working label Jun 21, 2021
@XiaoPangxie732 XiaoPangxie732 self-assigned this Jun 21, 2021
@XiaoPangxie732 XiaoPangxie732 added this to To do in Current Progress via automation Jun 21, 2021
XiaoPangxie732 added a commit that referenced this issue Jun 21, 2021
@XiaoPangxie732
Currently, the best way to solve #17
ecc3c44
@XiaoPangxie732 XiaoPangxie732 moved this from To do to In progress in Current Progress Jun 23, 2021
Current Progress automation moved this from In progress to Done Jun 25, 2021
@XiaoPangxie732 XiaoPangxie732 changed the title [BUG] [2.3-SNAPSHOT] Field duplicate when remapping [BUG] [2.3-SNAPSHOT] Field/Method duplicate when remapping Jun 26, 2021
@XiaoPangxie732 XiaoPangxie732 pinned this issue Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@XiaoPangxie732 XiaoPangxie732

Labels
bug Something isn't working
Projects
No open projects
Current Progress
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@XiaoPangxie732