Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promethion ready - checklist #142

Closed
5 tasks done
WardDeb opened this issue Jan 3, 2024 · 2 comments
Closed
5 tasks done

promethion ready - checklist #142

WardDeb opened this issue Jan 3, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@WardDeb
Copy link
Member

WardDeb commented Jan 3, 2024

Todo's to make the workflow 'promethion ready'. Related to #138, #139, #140

  • merge basecalled bam files (e.g. basecalled output)
  • fetch exact dorado (server) version + model used in MinKNOW and store this in the config / metadata to ship to end user. For MinKNOW v 23.07.12 the information in the json is confusing (e.g. guppy flags while dorado is used), the info in html should be correct.
  • basecalled bam files generated with minKNOW are not compatible with dorado align (v0.4.1 & 0.5.0).
  • basecalled bam files generated with minKNOW are not compatible with modbam2bed.
  • model_def & model are confusing in the metadata yaml (HAC vs SUP)
@WardDeb WardDeb added the enhancement New feature or request label Jan 3, 2024
@WardDeb
Copy link
Member Author

WardDeb commented Jan 31, 2024

per on site meeting:

  • parameters should be parsed from sequencingrun.html files rather then json/md
  • important to discriminate between minKNOW version/models & dorado models
  • bam header information should be parsed for consistency
  • explore expansion on epi2me's basecalling workflow for implementation into minKNOW

@caballero
Copy link
Contributor

merge basecalled bam files (e.g. basecalled output)
Implemented
fetch exact dorado (server) version + model used in MinKNOW and store this in the config / metadata to ship to end user. For MinKNOW v 23.07.12 the information in the json is confusing (e.g. guppy flags while dorado is used), the info in html should be correct.
Correct version is captured from html and json reports, added software versions of the other programs too
basecalled bam files generated with minKNOW are not compatible with dorado align (v0.4.1 & 0.5.0).
As basecalling and alignment is done in MinKNOW, this is not required
basecalled bam files generated with minKNOW are not compatible with modbam2bed.
Changed modbam2bed with modkit
model_def & model are confusing in the metadata yaml (HAC vs SUP)
Model is parsed from JSON, not need to run this separately
parameters should be parsed from sequencingrun.html files rather then json/md
Implemented, but most parameters are defined in the json
important to discriminate between minKNOW version/models & dorado models
We are capturing all versions reported
bam header information should be parsed for consistency
This was not implemented as bam header can contain or not the model (i.e. CL:dorado basecaller hac,m6A ...)
explore expansion on epi2me's basecalling workflow for implementation into minKNOW
todo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants