Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing on inverted quotes #11

Open
pepelsbey opened this issue Oct 8, 2015 · 3 comments
Open

Failing on inverted quotes #11

pepelsbey opened this issue Oct 8, 2015 · 3 comments

Comments

@pepelsbey
Copy link

Unfortunately it’s quite common pattern people copy from the spec:

<source src="video/windowsill.ogv" type='video/ogg; codecs="theora, vorbis"'>

And I see the following error:

/Users/pepelsbey/Projects/Opera/Dev.Opera/Site/node_modules/gulp-beml/node_modules/map-stream/index.js:103
        throw err
        ^
Error: Parse Error: <source src="video/windowsill.webm" type="video/webm; codecs="vp8, vorbis"">
        <source src="video/windowsill.ogv" type="video/ogg; codecs='theora, vorbis'">
      </video>
      </div>
    </div>
@maxpoletaev
Copy link
Owner

In my case single quotes are replaced by double quotes. But without crashing.
I know this bug as cheeriojs/cheerio#720. I can't fix it.

@voischev
Copy link

:(

@pepelsbey
Copy link
Author

Sorry for calling it a crash, this is just my build failing. The rest is the same as in your case. Is there any other good alternative to cheerio? This is a serious ussue, since I should maintain a certain code quality to be able to use BEML :\

@pepelsbey pepelsbey changed the title Crashing on inverted quotes Failing on inverted quotes Oct 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants