New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split JSON Out of Swiftz #274
Comments
👍 No idea what it should be called, though… |
I think you are right, it is the only section of Swiftz that requires Foundation and is completely separate in principle from the rest of the library. We could separate it out. I think there are a couple of paths.
|
I was thinking the 2nd, as we've had so much success with it in the past (see Concurrent, Focus, Swiftx). If users still wish to use Swiftx and Swiftz, they can update their cartfiles and pods as much. |
@CodaFi To clarify, do you mean to separate the Swift JSON parsing in Swiftz into a separate framework (like you are saying with Concurrent, Focus, Swiftx, etc) or to deprecate/remove it entirely and give a migration path to users of Swiftz to use another library like Argo? |
I mean we create our own package and keep everything within the typelift ecosystem following the models of those aforementioned frameworks, then deprecate Swiftz's stuff and put out a new point-release. |
Also, seeing as you've probably got more edits of that code than anyone (probably even Max at this point), I think you deserve admin access to anything we create. Even to TypeLift as a whole if you're up for it. |
@CodaFi I'm up for it, thanks. Any thoughts about the name of the new package? |
Great! OK, well
|
Or just something with a hard |
I like those ideas. Tyro or Thessalus would be good. Also, we could consider Zetes (The Boreads, brothers Calais and Zetes) "They were Argonauts and played a particularly vital role in the rescue of Phineus from the harpies." since it contains a z. |
Another option along the same lines would be Alcimede. |
I like Tyro for length, Zetes for the pun, and Alcimede because she's a badass. Any more, or start narrowing? |
I think these are good options. I also like Tyro for the length, Zetes because of the inclusion of z, and Alcimede sounds good. |
Oh, I've always wanted to name something janeway, or in this case JWay |
XD |
Janeway would be alright. JWay would sound a little too much like a Java framework. |
Well, @mpurland you have the rights to do whatever you like right now. Go ahead and pick a name and a make a new repository. Would you like us to close out all the existing pull requests and try again on the new repo after it's made, or would you prefer we merge first and ask questions later? |
@CodaFi Thanks. Yes, let's merge what is currently there (if it makes sense) and then start using the latest in master as a base. What do you think? |
👍 Let's do it. |
@CodaFi This is a first pass. I'll create the official repository after I can put a little more time into it. Take a look here: https://github.com/mpurland/Tyro |
I believe it's ready to be reviewed (https://github.com/mpurland/Tyro). Let me know what you think. I've added Travis CI integration and have ~75% test code coverage so far. I'll be adding more tests later with exact tests around the same json-data as Aeson and performance tests around large json data sets. |
@mpurland's recent pull requests have made it clear to me that it would be more useful to have JSON exist outside of this framework. Because it remains the one component that doesn't interact all that much with Swiftz as a whole, and is the last thing that requires Foundation, I figure it would do just fine as a standalone framework.
Names, comments, criticisms, objections?
The text was updated successfully, but these errors were encountered: