Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: scale down of pools does not work #80

Open
AmitKumarDas opened this issue Feb 4, 2020 · 0 comments
Open

bug: scale down of pools does not work #80

AmitKumarDas opened this issue Feb 4, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@AmitKumarDas
Copy link

AmitKumarDas commented Feb 4, 2020

Title: scaling down pools does not work in CStorClusterConfig
Recreation Steps: Create CStorClusterConfig with defaults auto set by controller. Edit the CStorClusterConfig with MinPoolCount set to 2.
Expect: CStor pools should scale down from 3 to 2.
Actual: CStor pools remain at 3
Other Details: There is a visible skew in MinPoolCount in last applied state vs. specs.

  basic > kubectl -n openebs get cstorclusterconfig -oyaml
apiVersion: v1
items:
- apiVersion: dao.mayadata.io/v1alpha1
  kind: CStorClusterConfig
  metadata:
    annotations:
      52234ef9-4702-11ea-a70d-42010a800115/gctl-last-applied: '{"apiVersion":"dao.mayadata.io/v1alpha1","kind":"CStorClusterConfig","metadata":{"name":"my-cstor-cluster","namespace":"openebs"},"spec":{"diskConfig":{"minCapacity":107374182400,"minCount":2},"maxPoolCount":0,"minPoolCount":3,"poolConfig":{"raidType":"mirror"}}}'
      52234ef9-4702-11ea-a70d-42010a800115/updated-due-to-watch: dao.mayadata.io-v1alpha1-CStorClusterConfig-openebs-my-cstor-cluster
      kubectl.kubernetes.io/last-applied-configuration: |
        {"apiVersion":"dao.mayadata.io/v1alpha1","kind":"CStorClusterConfig","metadata":{"annotations":{},"name":"my-cstor-cluster","namespace":"openebs"},"spec":{"diskConfig":{"externalProvisioner":{"csiAttacherName":"pd.csi.storage.gke.io","storageClassName":"csi-gce-pd"}},"poolConfig":{"raidType":"mirror"}}}
    creationTimestamp: "2020-02-04T03:56:28Z"
    generation: 3
    name: my-cstor-cluster
    namespace: openebs
    resourceVersion: "23778614"
    selfLink: /apis/dao.mayadata.io/v1alpha1/namespaces/openebs/cstorclusterconfigs/my-cstor-cluster
    uid: 52234ef9-4702-11ea-a70d-42010a800115
  spec:
    diskConfig:
      externalProvisioner:
        csiAttacherName: pd.csi.storage.gke.io
        storageClassName: csi-gce-pd
      minCapacity: 107374182400
      minCount: 2
    maxPoolCount: 0
    minPoolCount: 2
    poolConfig:
      raidType: mirror
kind: List
metadata:
  resourceVersion: ""
  selfLink: ""
  basic > kubectl -n openebs get cstorclusterplan -oyaml
apiVersion: v1
items:
- apiVersion: dao.mayadata.io/v1alpha1
  kind: CStorClusterPlan
  metadata:
    annotations:
      52234ef9-4702-11ea-a70d-42010a800115/gctl-last-applied: '{"apiVersion":"dao.mayadata.io/v1alpha1","kind":"CStorClusterPlan","metadata":{"annotations":{"dao.mayadata.io/cstorclusterconfig-uid":"52234ef9-4702-11ea-a70d-42010a800115"},"name":"my-cstor-cluster","namespace":"openebs"},"spec":{"nodes":[{"name":"gke-amitd-dao-d-default-pool-fcc50975-wt3x","uid":"bb3318c7-1b11-11ea-a90b-42010a800016"},{"name":"gke-amitd-dao-d-default-pool-fcc50975-blz8","uid":"bb3c94a2-1b11-11ea-a90b-42010a800016"},{"name":"gke-amitd-dao-d-default-pool-fcc50975-fvsb","uid":"ba217ce0-1b11-11ea-a90b-42010a800016"}]}}'
      dao.mayadata.io/cstorclusterconfig-uid: 52234ef9-4702-11ea-a70d-42010a800115
      metac.openebs.io/created-due-to-watch: 52234ef9-4702-11ea-a70d-42010a800115
    creationTimestamp: "2020-02-04T03:56:28Z"
    generation: 1
    name: my-cstor-cluster
    namespace: openebs
    resourceVersion: "23774136"
    selfLink: /apis/dao.mayadata.io/v1alpha1/namespaces/openebs/cstorclusterplans/my-cstor-cluster
    uid: 5226123b-4702-11ea-a70d-42010a800115
  spec:
    nodes:
    - name: gke-amitd-dao-d-default-pool-fcc50975-wt3x
      uid: bb3318c7-1b11-11ea-a90b-42010a800016
    - name: gke-amitd-dao-d-default-pool-fcc50975-blz8
      uid: bb3c94a2-1b11-11ea-a90b-42010a800016
    - name: gke-amitd-dao-d-default-pool-fcc50975-fvsb
      uid: ba217ce0-1b11-11ea-a90b-42010a800016
kind: List
metadata:
  resourceVersion: ""
  selfLink: ""
@AmitKumarDas AmitKumarDas changed the title bug: Skew between last applied state & actual specs in CStorClusterConfig bug: skew between last applied state & actual specs in CStorClusterConfig Feb 4, 2020
@AmitKumarDas AmitKumarDas added the bug Something isn't working label Feb 4, 2020
@AmitKumarDas AmitKumarDas changed the title bug: skew between last applied state & actual specs in CStorClusterConfig bug: scale down of pools does not work Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant