Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forgot password flow #54

Closed
tmyracle opened this issue Jan 14, 2024 · 13 comments
Closed

Add forgot password flow #54

tmyracle opened this issue Jan 14, 2024 · 13 comments

Comments

@tmyracle
Copy link
Contributor

Auth0 previously provided this functionality. We'll need to do a few things to replace that, off the top of my head:

  • Update sign in page with "Forgot password?" link
  • Add forgot password UI to capture email and show confirmation once forgot password email is sent
  • UI for specifying new password after clicking link in forgot password email
  • Generate token and handle token validation for sending email and when user clicks on the link in the forgot password email
  • Update server for handling sending the emails

This is low priority for right now.

@Shpigford Shpigford added this to the v1.0.0 milestone Jan 14, 2024
@sy425191
Copy link
Contributor

I would like to work on this

@Neumand
Copy link
Contributor

Neumand commented Jan 15, 2024

Same, I'd love to help on this

@Shpigford
Copy link
Member

Whoever would like to work on, go for it. Generally speaking, if you start working on, create a draft PR to show your progress.

That can help reduce multiple people working on the same issue.

@eneskaya
Copy link
Contributor

I'm still on it, please see #117 . Having a hard time testing with Postmark, though. Can't send an email to my private address 😅 Probably need to set up an own domain so I can test this.

What's missing now is:

  • UI for actually resetting the email + hooking it up with the BE to do the reset
Bildschirmfoto 2024-01-20 um 16 41 33 Bildschirmfoto 2024-01-20 um 16 41 46

@tmyracle
Copy link
Contributor Author

@eneskaya are the email templates managed in Postmark itself? I can't seem to find any in the repo and looks like its just referencing them by id. Might make sense to move to something like React Email so that the templates are in source control and you can style them with React and Tailwind. They also play nice with Postmark, Resend, Nodemailer, SendGrid, Plunk, and AWS SES

@Shpigford
Copy link
Member

There were indeed templates managed in Postmark, but we closed that account so lost access to them. :(

@eneskaya
Copy link
Contributor

@eneskaya are the email templates managed in Postmark itself? I can't seem to find any in the repo and looks like its just referencing them by id. Might make sense to move to something like React Email so that the templates are in source control and you can style them with React and Tailwind. They also play nice with Postmark, Resend, Nodemailer, SendGrid, Plunk, and AWS SES

That is a very good point. Right now I'm setting a raw text body, but wanted to bring up whether having the templates in the code base wouldn't make more sense. React Email would be a perfect candidate here, I agree! I will add it.

The issue still remains though with local testing, but we could wait with that until we have SMTP support, which would make testing easier.

@tmyracle
Copy link
Contributor Author

@Shpigford do you happen to have screenshots/examples?

rebuild

@Shpigford
Copy link
Member

@tmyracle Been digging a bunch and can't find anything. :( Will keep looking, but not looking great.

@eneskaya
Copy link
Contributor

@tmyracle Where exactly would you put the email templates?

@tmyracle
Copy link
Contributor Author

@eneskaya depends on what we decide to use for templating moving forward, my vote would be for React Email mentioned above since you can write emails as react components and it takes care of cross-client support and generating the html for you. Might have to put this on pause until we get a templating solution in place.

@eneskaya
Copy link
Contributor

@eneskaya depends on what we decide to use for templating moving forward, my vote would be for React Email mentioned above since you can write emails as react components and it takes care of cross-client support and generating the html for you. Might have to put this on pause until we get a templating solution in place.

I was talking about where to put them in the monorepo 😁 But let me create a new issue for the email templates, and we can discuss there

@Shpigford Shpigford removed this from the v1.0 milestone Jan 23, 2024
@tmyracle
Copy link
Contributor Author

tmyracle commented Feb 1, 2024

Not relevant anymore

@tmyracle tmyracle closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants