Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom template when allow_browser blocks a browser #637

Closed
zachgoll opened this issue Apr 16, 2024 · 4 comments · Fixed by #712
Closed

Add custom template when allow_browser blocks a browser #637

zachgoll opened this issue Apr 16, 2024 · 4 comments · Fixed by #712

Comments

@zachgoll
Copy link
Collaborator

Currently, we're showing a generic error message when a browser is blocked, making it hard to debug self-hosted apps:
image

We should add a custom public/406-unsupported-browser.html file to give the user more feedback.

This recently went into Rails main and used to be public/426.html - rails/rails#51545

@adrienpoly
Copy link
Contributor

adrienpoly commented May 4, 2024

The current setting is

allow_browser versions: :modern

I wonder if this is something you want to keep like that?

The main limitation is for Safari which is not evergreen and the current requirement is 17.2 with :modern, source

Here are the real world usage for Baseamp

https://x.com/dhh/status/1783888747769250255

17.2 Safari brings the :has css selector but I haven't seen any in the code base (very quick scan)

@zachgoll
Copy link
Collaborator Author

zachgoll commented May 4, 2024

@adrienpoly I don't have a super strong opinion on this one. As long as we're not spending significant dev hours trying to research and support differences across browsers and browser versions, I'd be open to making this less restrictive.

What setting would you recommend?

@adrienpoly
Copy link
Contributor

adrienpoly commented May 6, 2024

@zachgoll I don't have a strong opinion either. I wouldn't be worried about Chome/Firefox version as they are evergreen but more about Safari. Looking at Basecamp data it feels like only 56% of their Safari users would be able to access the site with the current configuration.

I am unsure what is the typical user of your solution when it is live but as it is personal finances I believe lots of users won't be as techy as we (developers) are and could easily run an older version on their mac at home.

Also it depends when the release date is scheduled for. As explained in the PR this is a proposed setting for Rails 8 that is not released right now. By the time it is released maybe the usage stats will be much different.

On my side I would probably put a Safari >= 16.0 as I don't feel you are doing edgy things with CSS

@zachgoll
Copy link
Collaborator Author

zachgoll commented May 6, 2024

@adrienpoly yeah I think Safari >= 16 would be reasonable, and then keep the "modern" version requirements for the remaining browsers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants