Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: review categories dropdown on transactions #659

Closed
3 tasks
mattia-malnis opened this issue Apr 21, 2024 · 1 comment
Closed
3 tasks

Improvement: review categories dropdown on transactions #659

mattia-malnis opened this issue Apr 21, 2024 · 1 comment

Comments

@mattia-malnis
Copy link
Contributor

There are a few improvements and bugs that should be addressed in the categories dropdown:

  • Bug: When a category is edited, an error occurs on save (see video below);
  • Bug: If you try to create a category and leave the first color selected by default, nothing happens;
  • Improvement: Every action inside the controller that handles categories performs a redirect to transactions_path, which could be misleading for a user who is on the dashboard or the account details page.
Registrazione.schermo.2024-04-21.alle.15.08.02.mov

A potential solution could be to remove the categories dropdown from every transaction line and load the categories asynchronously every time the dropdown is opened (this action should be infrequent as the category is assigned during transaction creation). By doing so, it should be easier to update the categories dropdown frame during the creation/edit process because there would be only one instance of it.

@zachgoll
Copy link
Collaborator

zachgoll commented May 2, 2024

Should all be addressed by #679

@zachgoll zachgoll closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants