Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exit silently if no raw_data #42

Closed
gregroberts opened this issue Jan 28, 2019 · 1 comment
Closed

exit silently if no raw_data #42

gregroberts opened this issue Jan 28, 2019 · 1 comment

Comments

@gregroberts
Copy link
Contributor

if not raw_data:
sys.exit()

Exiting silently when raw_data is empty seems like unreasonable behaviour.

This should either return an empty dataframe, or raise pandas.errors.EmptyDataError.

Context: I use this library with Luigi as part of an ETL workflow. When raw_data is empty, the whole thing exits without giving any signal as to why.

Happy to draw up a PR if you'd prefer.

@maybelinot
Copy link
Owner

Good catch, yes, I'd appreciate a PR. Thanks @gregroberts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants