Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PSR12.Traits.UseDeclaration #146

Closed
1 of 7 tasks
Khartir opened this issue Nov 29, 2019 · 1 comment · Fixed by #147
Closed
1 of 7 tasks

Add PSR12.Traits.UseDeclaration #146

Khartir opened this issue Nov 29, 2019 · 1 comment · Fixed by #147
Milestone
5.0.0

Comments

@Khartir
Copy link
Contributor

Khartir commented Nov 29, 2019

Type of issue

  • Bug in MO4 sniffer rule.
  • Bug in MO4 auto-fixer.
  • Bug in MO4 documentation.
  • Request to extend MO4 sniffer with specific rule.
  • Request to extend MO4 auto-fixer for specific rule.
  • Request to extend MO4 documentation.
  • Other (explain):

Description

#144 does not enforce a blank line between trait imports and class constants.
This would be enforced by PSR12.Traits.UseDeclaration, which is available with phpcs 3.5.0.
@mmoll
Copy link
Contributor

mmoll commented Nov 29, 2019

@Khartir Please open a PR which also raises the respective requirement.

@mmoll mmoll added this to the 5.0.0 milestone Nov 29, 2019
@Khartir Khartir mentioned this issue Dec 2, 2019
Merged
2 tasks
@mmoll mmoll closed this as completed in #147 Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Require blank lines after traits Khartir/mo4-coding-standard
2 participants
@mmoll @Khartir