Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get rid of opencv #56

Closed
Mayukhdeb opened this issue Nov 20, 2023 · 0 comments · Fixed by #59
Closed

get rid of opencv #56

Mayukhdeb opened this issue Nov 20, 2023 · 0 comments · Fixed by #59
Labels
good first issue Good for newcomers

Comments

@Mayukhdeb
Copy link
Owner

it's a relatively big dependency in terms of size, but I'm barely getting any use out of it.

Steps:

  1. find out where opencv is used
  2. find viable replacements of those opencv operations with numpy, PIL or ImageIO
  3. replace them one at a time
  4. pass all tests
@Mayukhdeb Mayukhdeb added the good first issue Good for newcomers label Nov 20, 2023
@sushmanthreddy sushmanthreddy mentioned this issue Mar 16, 2024
Merged
Mayukhdeb added a commit that referenced this issue Mar 25, 2024
@Mayukhdeb
(close #56) Merge pull request #59 from sushmanthreddy/opencv
bfb1696 
use imageio instead of opencv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added the imageio instead of opencv sushmanthreddy/torch-dreams
1 participant
@Mayukhdeb