Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve/rename pat_internalData() #27

Closed
jonathancallahan opened this issue Mar 29, 2019 · 0 comments
Closed

improve/rename pat_internalData() #27

jonathancallahan opened this issue Mar 29, 2019 · 0 comments
Assignees
@jonathancallahan
Labels
enhancement New feature or request
Projects
AirSensor 0.2

Comments

@jonathancallahan
Copy link
Member

This function does simple subsetting of the columns of data in pat$data and then does one of two things:

  • returns the dataframe
  • plots the dataframe

It's probably a less confusing to have separate functions for extraction and plotting.

Also, the plotting function needs to spit out a warning if attempting to plot more than # records X # different parameters.
@jonathancallahan jonathancallahan added the enhancement New feature or request label Mar 29, 2019
@jonathancallahan jonathancallahan self-assigned this Mar 29, 2019
@jonathancallahan jonathancallahan added this to To do in AirSensor 0.1 via automation Mar 29, 2019
@jonathancallahan jonathancallahan removed this from To do in AirSensor 0.1 Apr 4, 2019
@jonathancallahan jonathancallahan added this to To do in AirSensor 0.2 via automation Apr 4, 2019
AirSensor 0.2 automation moved this from To do to Done Apr 4, 2019
AirSensor 0.2 automation moved this from Done to In progress Apr 4, 2019
AirSensor 0.2 automation moved this from In progress to Done Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathancallahan jonathancallahan

Labels
enhancement New feature or request
Projects
No open projects
AirSensor 0.2
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonathancallahan