Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve pat_scatterplot() #31

Closed
4 tasks done
jonathancallahan opened this issue Apr 5, 2019 · 0 comments
Closed
4 tasks done

improve pat_scatterplot() #31

jonathancallahan opened this issue Apr 5, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@jonathancallahan
Copy link
Member

jonathancallahan commented Apr 5, 2019

The pat_scatterplot() is a good working example but can be improved.

If it's not too hard, we should convert it to ggplot graphics.

Desirable features:

  • parameters argument -- We should allow people to pass in a vector of the parameters they want to generate scatterplots for. Any combination of pat internal variables should be OK. But we also want to default to datetime, A, B, temp, humidity.
  • graphical parameters optimized for speed -- shape = 18? or '.'
  • sampleFraction argument -- For large data frames we will optimize things by randomly sampling the data. The sampleFraction argument should default to NULL which means we subsample to get a data frame with a reasonable number of rows, say 1e5. But users will be allowed to set this parameter to 1 if they want to force it to plot everything or a low number if they want to speed things up
  • ... argument -- We should allow people to supply extra graphical parameters to customize the plot like color, size, shape, etc.
@jonathancallahan jonathancallahan added the enhancement New feature or request label Apr 5, 2019
@jonathancallahan jonathancallahan added this to To do in AirSensor 0.2 via automation Apr 5, 2019
@hmrtn hmrtn moved this from To do to In progress in AirSensor 0.2 Apr 17, 2019
@hmrtn hmrtn closed this as completed Apr 17, 2019
AirSensor 0.2 automation moved this from In progress to Done Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
AirSensor 0.2
  
Done
Development

No branches or pull requests

2 participants