Properly show symbol kinds and structs/modules in document outline

[mwpenny]

While trying to understand the details of DocumentSymbolProvider, I found these small mistakes.

1. If a regex for macros is defined (true for all language IDs other than asm-list-file) then processing of modules, structs, and symbol kinds is skipped.

   • Before
     
   • After
     

2. If a label immediately follows a constant or data symbol, then the wrong symbol kind is used.

   • Example
     
   • Before
     
   • After
     

For the screenshots, I used tests/modulesstruct.asm.

[mwpenny]

Rather than continueing if the regex is defined, the continue now only happens if there was actually a match.

[mwpenny]

Updating defaultSymbolKind seems unnecessary since this code will always go back and update all lastSymbols if required anyway. Let me know if this is incorrect.

Removing defaultSymbolKind also simplifies the code a bit.

[maziac]

Your PR makes sense. Seems that I broke my code some time.
I would like to remember what the reason for this code was:

                    // Check if found
                    if (kind != undefined) {
                        // It's something else than code
                        for (const elem of lastSymbols) {
                            elem.kind = kind;
                            elem.detail = match![1] + ' ' + match![2].trimEnd();
                        }
                        defaultSymbolKind = kind;
                    }

Seems that there was some special implementation for constants (equ).

[maziac]

Ahh. Sorry, I forgot to ask:
Is your PR under MIT license?

[mwpenny]

Yes, I agree that my code can be released under the same license as the rest of this project (MIT).

[maziac]

Thanks.

[mwpenny]

@maziac From what I can tell, the block you mentioned handles cases where multiple labels refer to the same constant/data. For example:

; All labels will be have the same vscode.SymbolKind applied (SymbolKind.Field)
label1:
label2:
label3:
    defb 123

The code keeps track of all consecutive symbols in lastSymbols and then goes back and updates their kind if necessary once a constant or data definition is encountered.

[maziac]

Thanks.