Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Arch Linux] Newer dependencies breaking Melanobot through Melanolib #75

Open
surkeh opened this issue Sep 2, 2017 · 2 comments
Open

Comments

@surkeh
Copy link
Contributor

surkeh commented Sep 2, 2017

On Arch Linux, using openssl 1.1, gcc 7.1.1

I believe the Melanolib was updated more recently than Melanobot. The preprocessor detects compiler version and sets melanolib::variant to std::variant but std::variant doesn't seem to have the member function which() which boost::variant does. This appears to be desired behavior from your library but it currently breaks Melanobot_v2. As a workaround, I had the preprocessor set melanolib::variant to boost::variant.

Second issue is that object.hpp in Melanolib requires C++17 here, but Melanolib is set to use C++14. I set all libs using 14 to 17 as a workaround.

Although unrelated to this issue, after fixing #74, and running cmake with the -DHTTPONY_SHARED=ON argument, Melanobot compiled.

@mbasaglia
Copy link
Owner

I can add a compiler switch/macro to force using boost variant, as for any and optional

@surkeh surkeh changed the title Melanolib updates breaking Melanobot [Arch Linux] Newer dependencies breaking Melanobot through Melanolib Sep 3, 2017
@surkeh
Copy link
Contributor Author

surkeh commented Sep 3, 2017

Sounds like a good solution. Not an issue on Devuan, OpenSSL 1.0, gcc 6.3.0 20170516, cmake 3.7.2. Hopefully won't be an issue for most running a server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants