Memory leak if ecdsa_sign/ecdsa_verify fail with an error

[DualTachyon]

The sign&verify functions will not free up some mpi's if they fail.
I used the alpha 1.3.1 that was released a couple of months ago.

[pjbakker]

We will check this out and fix accordingly. Thanks for noticing.

[pjbakker]

Can you elaborate? All MPIs initialized in the sign and verify functions are cleared as well.

Are you referring to the MPIs in the group? You should free the group yourself outside of the sign and verify functions.

[DualTachyon]

For example, ecdsa_verify declares (from https://github.com/polarssl/polarssl/blob/polarssl-1.3/library/ecdsa.c)

Line 118: mpi e, s_inv, u1, u2;
Line 119: ecp_point R, P;

These variables are freed at line 171,172 in the success case, but not if R is zero @ line 161 or if the signature fails @ line 167.

[pjbakker]

Correct.. Fixed in cca998a