Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible memory leak if someone runs the benchmarks in a loop. #43

Closed
Thuffir opened this issue Dec 13, 2013 · 1 comment
Closed

Possible memory leak if someone runs the benchmarks in a loop. #43

Thuffir opened this issue Dec 13, 2013 · 1 comment

Comments

@Thuffir
Copy link
Contributor

Thuffir commented Dec 13, 2013

The GCM context does not get freed in programs/test/benchmark.c. There is a missing gcm_free() after line 300.
@pjbakker
Copy link
Contributor

Fixed for the next release.

AnttiKauppila pushed a commit to JarkkoPaso/mbedtls that referenced this issue Aug 18, 2017
@mpg
Clarify documentation for directly-trusted certs
a4a206e 
The fact that self-signed end-entity certs can be explicitly trusted by
putting them in the CA list even if they don't have the CA bit was not
documented though it's intentional, and tested by "Certificate verification Mbed-TLS#73
(selfsigned trusted without CA bit)" in test_suite_x509parse.data

It is unclear to me whether the restriction that explicitly trusted end-entity
certs must be self-signed is a good one. However, it seems intentional as it is
tested in tests Mbed-TLS#42 and Mbed-TLS#43, so I'm not touching it for now.
mpg added a commit that referenced this issue Mar 6, 2018
@mpg
Clarify documentation for directly-trusted certs
ab7796f 
The fact that self-signed end-entity certs can be explicitly trusted by
putting them in the CA list even if they don't have the CA bit was not
documented though it's intentional, and tested by "Certificate verification #73
(selfsigned trusted without CA bit)" in test_suite_x509parse.data

It is unclear to me whether the restriction that explicitly trusted end-entity
certs must be self-signed is a good one. However, it seems intentional as it is
tested in tests #42 and #43, so I'm not touching it for now.
mpg added a commit that referenced this issue Mar 6, 2018
@mpg
Clarify documentation for directly-trusted certs
3a13084 
The fact that self-signed end-entity certs can be explicitly trusted by
putting them in the CA list even if they don't have the CA bit was not
documented though it's intentional, and tested by "Certificate verification #73
(selfsigned trusted without CA bit)" in test_suite_x509parse.data

It is unclear to me whether the restriction that explicitly trusted end-entity
certs must be self-signed is a good one. However, it seems intentional as it is
tested in tests #42 and #43, so I'm not touching it for now.
@AndrzejKurek AndrzejKurek mentioned this issue Feb 7, 2019
Merged
gilles-peskine-arm pushed a commit to gilles-peskine-arm/mbedtls that referenced this issue Mar 1, 2019
@Patater
Merge pull request Mbed-TLS#43 from Patater/update-2.16-dev
2a0f48a 
Update to a development version of Mbed TLS 2.16.0
hanno-becker pushed a commit to hanno-becker/mbedtls that referenced this issue Oct 12, 2020
Merge pull request Mbed-TLS#43 from hannestschofenig/sign_alg_handling
3f71cc4 
Add signature algorithm configuration
gilles-peskine-arm pushed a commit that referenced this issue Apr 21, 2021
@mpg @gilles-peskine-arm
Clarify documentation for directly-trusted certs
f7ec0d2 
The fact that self-signed end-entity certs can be explicitly trusted by
putting them in the CA list even if they don't have the CA bit was not
documented though it's intentional, and tested by "Certificate verification #73
(selfsigned trusted without CA bit)" in test_suite_x509parse.data

It is unclear to me whether the restriction that explicitly trusted end-entity
certs must be self-signed is a good one. However, it seems intentional as it is
tested in tests #42 and #43, so I'm not touching it for now.
iameli pushed a commit to livepeer/mbedtls that referenced this issue Dec 5, 2023
@jfigus
Merge pull request Mbed-TLS#43 from ukreator/master
ea3d9ed 
Memory access fixes.  Thanks for contributing this fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pjbakker @Thuffir