Broken symlink created during bundling

[arimer]

When creating a .dmg file containing the application a broken symlink is still created under

Application/MyAppapp/Contents/bin/*.dylib

To verify this for your application you could just use the following command to find the
broken link:

find . -type l ! -exec test -e {} \; -print

It looks like the following code is always executed. I will add a condition there.

mps-gradle-plugin/src/main/resources/de/itemis/mps/gradle/mpssign.sh

Line 47 in 3ac8f05

for f in "$CONTENTS/bin"/*.jnilib; do

[arimer]

Just saw that we have duplicated and outdated code in two scripts:

mps-gradle-plugin/src/main/resources/de/itemis/mps/gradle/bundle_macos_jdk.sh

Line 33 in 3ac8f05

if ls "$CONTENTS/bin"/*.jnilib >& /dev/null; then

and

mps-gradle-plugin/src/main/resources/de/itemis/mps/gradle/mpssign.sh

Line 47 in 3ac8f05

for f in "$CONTENTS/bin"/*.jnilib; do

I am not sure if we want to keep both of it, because it seems to be only relevant for older MPS versions.

[sergej-koscejev]

@arimer you probably meant one of the files to be mpssign.sh in your comment.

We should call bundle_macos_jdk.sh from mpssign.sh, and remove most of the code from mpssign.sh except for the argument parsing and signing.

mpssign.sh should:

1. Parse arguments (also check the SIGN_ arguments before the script does anything)
2. Call bundle_macos_jdk.sh with appropriate args (if no JDK was given, pass empty string as JDK)
3. Do the signing stuff (code beginning with echo "Signing application $BUILD_NAME", up to echo "check sign done").

[arimer]

Could we maybe agree to merge first the simple change introduced here: #27

And afterwards refactor the buildscripts?

[sergej-koscejev]

@arimer sure :)