[USBDevice] Fix for https://github.com/mbedmicro/mbed/issues/690 #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the old K64F register .h file (same for K22F), SIM_SOPT2_PLLFLLSEL_MASK was incorrectly set as a 1-bit field, like it was in the KLXX devices, while it now is a 2-bit field. This has been fixed in the current register maps, however the USB clock was set by taking the entire mask, while only the first bit needs to be set. This is now fixed by using the SHIFT definition, and should work also on other Freescale targets (verified on K64, K22 and KL25)
|
Also if it makes anyone feel better: The exact same bug is also in the official clock setup files for USB enabled clock. However since USBDevice overwrites it anyway it doesn't matter for us. Someone might mention it to them though. |
|
I've just tried out this fix on Windows, and it seems to have fixed the problem I was having - I will try on Linux and OSX in the next few days to see if there are any issues, but I can't imagine that there will be any. |
|
@Sissors , please update you branch to the latest master for the future, I had to resolve conflicts because your branch was behind master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the old K64F register .h file (same for K22F),
SIM_SOPT2_PLLFLLSEL_MASK was incorrectly set as a 1-bit field, like it
was in the KLXX devices, while it now is a 2-bit field. This has been
fixed in the current register maps, however the USB clock was set by
taking the entire mask, while only the first bit needs to be set.
This is now fixed by using the SHIFT definition, and should work also on
other Freescale targets (verified on K64, K22 and KL25)
Also the sooner you decide on my other pull request the sooner they can be automatically merged again ;)