Skip to content
This repository has been archived by the owner on Nov 22, 2021. It is now read-only.

Complete selected tags #30

Closed
KrisBraun opened this issue Nov 29, 2013 · 5 comments
Closed

Complete selected tags #30

KrisBraun opened this issue Nov 29, 2013 · 5 comments

Comments

@KrisBraun
Copy link

When selecting an autocomplete tag (using the mouse or enter), it'd be great if it appeared in the text input as a tag rather than editable text. Could be an option if some need it to be editable.

@mbenford
Copy link
Owner

Hi again!

Yes, I have noticed that already, but forgot to create an issue for it. So let this one be it. :)

Thanks for reporting it!

Kind regards.

@KrisBraun
Copy link
Author

I hacked a fix for this by exposing tryAdd on the tagsInput controller, and then called it when a selection is made.

@KrisBraun
Copy link
Author

Sorry for not producing proper PRs -- quickly fixing a couple things and not sure if they're the best fixes. But if you like, I could do it the right way this weekend.

@mbenford
Copy link
Owner

I'd appreciate it. :)

@mbenford
Copy link
Owner

mbenford commented Dec 2, 2013

I've figured that adding the selected suggestion as a tag is way more useful than just filling the input and requiring the user to do the rest. So I've changed the directive's code accordingly, instead of keeping both behaviors.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants