Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving to Poetry as a dependency management tool #23

Closed
nenkoru opened this issue Feb 8, 2022 · 5 comments
Closed

Moving to Poetry as a dependency management tool #23

nenkoru opened this issue Feb 8, 2022 · 5 comments

Comments

@nenkoru
Copy link
Contributor

nenkoru commented Feb 8, 2022

I have been thinking that Poetry would be a great way to control dependencies.

  • It would eliminate having different files for development dependencies, and production ones
  • It would automatically control and update dependencies when possible, without collisions(which currently happen on nbmake and pytest package)
  • It would automatically create a virtual environment for developers to develop with
  • It would allow for easier publishing of the package to PyPI

As of by writing this Issue, Poetry's version is 1.1.12 and it doesn't allow to have testing dependencies yet, but in version 1.2 they would make it possible. For now, I think it would be best to keep testing dependencies in the development section of poetry.

@nenkoru nenkoru changed the title Moving to Poetry as a dependency management Moving to Poetry as a dependency management tool Feb 8, 2022
@nenkoru
Copy link
Contributor Author

nenkoru commented Feb 8, 2022

I already started migrating to Poetry as a dependency management tool in the fork of okama by 'poetry' branch.

@nenkoru
Copy link
Contributor Author

nenkoru commented Feb 10, 2022

I had a Teams conference call, where @chilango74 described moving to Poetry as a little bit challenging, as long as okama targets not only developers but also average users of Python with their conda environment. So the transition has to be scrutinized in that way as well

@chilango74
Copy link
Collaborator

Switching to poetry would affect only devlopers who install it with pip install git+https://github.com/mbk-dev/okama@dev. General users will still be able to install the package in anaconda environments. Hence moving to poetry seems to be a good idea.

@chilango74
Copy link
Collaborator

I'd also target including the package in the official anaconda channel. This way we would be able to use conda install okama too. Which is quite common for scientific packages.

@nenkoru
Copy link
Contributor Author

nenkoru commented Feb 12, 2022

Resolved in #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants