Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Configuration check prevents using --edit-config #15

Closed
Markus00000 opened this issue Aug 3, 2021 · 1 comment
Closed

[BUG] Configuration check prevents using --edit-config #15

Markus00000 opened this issue Aug 3, 2021 · 1 comment
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@Markus00000
Copy link

Markus00000 commented Aug 3, 2021

Describe the bug
When config.yaml contains unrecognized options, a ValueError prevents fixing them using webchanges --edit-config.

To Reproduce
Add unrecognized options to config.yaml manually with an editor, then try to remove them using webchanges --edit-config.

Expected behavior
Fixing a broken configuration should always be possible with --edit-config. If the configuration check is run after saving config.yaml, it can still warn about unrecognized options that have not been fixed. Another possibility would be to show a prompt with a warning message when invoking --edit-config with an invalid configuration.

Version info
2021-08-03 08:55:26,577 cli DEBUG: webchanges: 3.8.1 Copyright 2020- Mike Borsetti
2021-08-03 08:55:26,577 cli DEBUG: Python: ('default', 'Jun 30 2021 10:22:16')
2021-08-03 08:55:26,580 cli DEBUG: System: Linux-5.13.7-arch1-1-x86_64-with-glibc2.33

@mborsetti mborsetti self-assigned this Aug 3, 2021
@mborsetti mborsetti added bug Something isn't working enhancement New feature or request labels Aug 3, 2021
@mborsetti
Copy link
Owner

I just released v3.8.2, which fixes this logic error. Thanks so much for reporting it; very much appreciated! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants