Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additions_only: true , but still receive alert when no matched content found #6

Closed
Fedora7 opened this issue Apr 19, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@Fedora7
Copy link

Fedora7 commented Apr 19, 2021

I have additions_only: true in job config. When the matched content reduced from one found to nothing found, I received alert of the following. In this case, no addition is really found. Is this the expected behavior ? Thanks.

`---------------------------------------------------------------------------
CHANGED: index · web... ( http://..../ )

+++ @ Mon, 19 Apr 2021 16:02:01 -0700

--
Checked 1 source in 0.066 seconds with webchanges 3.4.1`

@mborsetti mborsetti added the question Further information is requested label Apr 20, 2021
@mborsetti
Copy link
Owner

mborsetti commented Apr 20, 2021

Thanks for the question!

I have seen additions_only reports consisting entirely of a new empty line; it may be the case here as well.

At the moment all additions get reported, even if it's all empty lines. Let me know if you think it may be useful to change this behavior.

@Fedora7
Copy link
Author

Fedora7 commented Apr 20, 2021

In most of my cases, I list the new things ( new product, new topic, new discussion thread, new video, etc ) that I am interested under additions_only and trigger the alert email to my phone. But these supposed to be exciting alerts became annoying. Since half of them are not about new things happening. The new things/events on web come and go quickly. If I want to know they are gone, I always have the option to use deletions_only directive or simply use diff_filter: grep: '^+' . The current behavior make the new shining feature of additions_only less useful. I vote for not reporting item that is gone if it's under additions_only. Thanks.

@mborsetti
Copy link
Owner

Agree. If anyone is interested in cosmetic changes they would not be using additions_only to begin with.

Will change the behavior of the filter to not report changes if they only consist of addition of blank lines.

Thanks for the report!

@mborsetti mborsetti added enhancement New feature or request and removed question Further information is requested labels Apr 20, 2021
@mborsetti
Copy link
Owner

Will change the behavior of the filter to not report changes if they only consist of addition of blank lines.

Version 3.5, just released, incorporates this improvement.

Thank you very much for opening an issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants