Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] requests is not installed by default but unconditionally imported #65

Closed
yubiuser opened this issue Dec 10, 2023 · 1 comment
Closed

Comments

@yubiuser
Copy link

Since 3.16 requests is not installed by default (e.g. removed from requirements.txt) and replaced by httpx. One import however is executed unconditionally:

import requests

This can lead to errors

/data/webchanges # webchanges --help
Traceback (most recent call last):
  File "webchanges.py", line 1, in <module>
  File "PyInstaller/loader/pyimod02_importers.py", line 419, in exec_module
  File "webchanges/cli.py", line 25, in <module>
  File "PyInstaller/loader/pyimod02_importers.py", line 419, in exec_module
  File "webchanges/util.py", line 25, in <module>

@mborsetti
Copy link
Owner

Apologies and thank you so very much for reporting it. Unfortunately, testing loads both libraries and therefore it didn't catch it.

Quick fix in 3.17.1 and will become conditional in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants