Short-circuit for speed.

Thanks, @mbostock!
d3 · Sep 29, 2011 · adec0a6 · adec0a6
1 parent 927426f
commit adec0a6
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/d3.js b/d3.js
@@ -1339,9 +1339,8 @@ d3_selectionPrototype.classed = function(name, value) {
       while (++i < n) d3_selection_classed.call(this, names[i], value);
       return this;
     } else {
-      value = true;
-      while (++i < n) value = value && d3_selection_classed.call(this, names[i]);
-      return value;
+      while (++i < n) if (!d3_selection_classed.call(this, names[i])) return false;
+      return true;
     }
   }
   return d3_selection_classed.apply(this, arguments);