Fix d3.selectAll(HTMLCollection)
#2376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…7c1ccac09d19287c11d2d115758aL61 - doing a d3.selectAll on an HTMLCollection resulted in broken calls to e.g. `.sort()` due to dropped conversion to a proper array
|
Merged into #2591. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a selection created via e.g.
var sel = d3.selectAll(someElement.children)used to work, but in 9c3df31#diff-d93c7c1ccac09d19287c11d2d115758aL61 a critical conversion tod3_arraywas factored out of that path. This resulted in such selections exploding when certain array-dependent methods were used, such assel.sort().Simple fix, plus now a test for this code path. (The existing test had only been exercising
sel.selectAllbut notd3.selectAll!)