Add support for parsing weekdays and week numbers. #764
Conversation
| var date = new d3_time(0); | ||
| if ("j" in d) { | ||
| date.setFullYear(d.y, 0, 1); | ||
| date.setTime(+date + d.j * 864e5); |
There was a problem hiding this comment.
Does this work correctly with daylight savings because we later call setHours?
There was a problem hiding this comment.
Good point! It turns out this is error-prone for some time zones e.g.:
var d = new Date(0);
d.setFullYear(2012, 0, 1);
d.setTime(+d + 100 * 864e5);
console.log(d);$ node tz.js
Tue Apr 10 2012 01:00:00 GMT+0100 (BST)
$ TZ=America/Scoresbysund node tz.js
Wed Apr 11 2012 00:00:00 GMT+0000 (EGST)Rather than fiddling with offsets directly, it turns out there's an elegant solution: simply pass the full day-of-year to setFullYear and it will automatically wrap to the correct month and day.
There was a problem hiding this comment.
I've fixed a similar issue for week-of-year/day-of-week parsing too.
|
Rebased against version 3.1.6. |
|
can this pull request be merged ? |
Also includes support for parsing "%" literals.
|
Can we include this in 3.2? It seems like a simple enough change. |
|
Sure, that sounds reasonable. I haven’t closely examined this pull request, but as a skim read, it looks good. |
|
Excellent, thanks. Staged in #1285 for 3.2. |
Also includes support for parsing "%" literals.