Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed back - A build pain #42

Closed
Itee opened this issue Jan 17, 2018 · 1 comment
Closed

Feed back - A build pain #42

Itee opened this issue Jan 17, 2018 · 1 comment

Comments

@Itee
Copy link

Itee commented Jan 17, 2018

Hello there !

First of all, thank for this package !

But... I was unable to build correctly the shapefile.js and shape.min.js
I try to build it using npm run prepublishOnly and i got some errors.

The first that i encountered is in the script pretest. the rm command is linux only ( sorry i'm under windows like 90% of people in the world 😩 ) maybe should you use a remover like del-cli in conjunction with make-dir-cli for the folder creation. They are cross-platform.

The second was the command cp which is linux too... Maybe the usage of cp-cli could help here too (cross-platform of course).

The third... tail same problem, maybe the same solution !

Then, the $preamble is not processed, so i got a $(preamble) in shapefile.js on top...

Fiouu...

Lot of stuff that you do in prepublishOnly script could be integrated inside the rollup.config like uglifyjs part.

The only thing that i was unable to fix is the tail part for build test file. Which, IMO, could be bundled by rollup entirely with an other config file.

If you need some help to make this package more cross-platform, i could give you a little PR about.

Best regards,
Itee

@mbostock
Copy link
Owner

Thanks for the feedback. Unfortunately, I don’t currently have the time or motivation to support other development platforms. You are welcome to fork this repository and add Windows support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants