Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wish chinese file path support #87

Closed
nefusmzj opened this issue Nov 17, 2021 · 4 comments
Closed

wish chinese file path support #87

nefusmzj opened this issue Nov 17, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@nefusmzj
Copy link

Now, It not support chinese file path, when save or open white board. I wish this project can support chinese file path in futher, thank you.

@nefusmzj nefusmzj added the enhancement New feature or request label Nov 17, 2021
@mbrlabs
Copy link
Owner

mbrlabs commented Nov 27, 2021

Do you mean you can't see files with chinese characters in the file dialog? If so it's probably because the font i'm using does not support Chinese. But it's pretty easy in Godot to change the font based on the locale, so i can add a chinese (maybe also a japanese) font the next release.

@mbrlabs
Copy link
Owner

mbrlabs commented Jun 14, 2022

@LGiki added a chinese font (and translation). Maybe this fixed it already. If not then maybe it's a good idea to add an additional mapping from the default fonts to the chinese ones when the application language is Chinese.

Same for Korean (i already added a font for that), but that's annother issue.

@LGiki
Copy link
Contributor

LGiki commented Jun 15, 2022

I did some tests, when the language is set to a language other than Simplified Chinese, the file paths containing Chinese characters cannot be displayed properly, for example: the 新建文件夹 in D:\temp\新建文件夹\ will be displayed as blank. But when the language is set to Simplified Chinese, it can be displayed properly. As shown in the following screenshot.

I also tested that even if the language is set to a language other than Simplified Chinese (paths containing Chinese characters cannot be displayed properly), Lorien can still open, save and export files to paths containing Chinese characters normally.

So if you want to use Lorien in a path containing Chinese characters, you can set the language to Simplified Chinese and everything will work fine.

@mbrlabs
Copy link
Owner

mbrlabs commented Jun 15, 2022

Great, thanks for testing! I think that's as good as it gets without completly changing all fonts, so i'm closing this as solved.

@mbrlabs mbrlabs closed this as completed Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants