Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uber bug with assets. #31

Closed
krukhlis opened this issue Oct 9, 2016 · 5 comments
Closed

Uber bug with assets. #31

krukhlis opened this issue Oct 9, 2016 · 5 comments
Labels

Comments

@krukhlis
Copy link
Contributor

krukhlis commented Oct 9, 2016

Ok, so the latest version has complitely redesigned assets manager. Which comes with lots of issues.
Please see the image attached.
textures_loading_management_issues

In short:

  1. The "Assets" menu lets you load only models, not textures.
  2. To load texture one can use only submenu of the button before "Gift box button".
  3. One can load the same texture multiple times which is waste of the resources.
  4. Assets outline shows only models, not textures. :(
@mbrlabs
Copy link
Owner

mbrlabs commented Oct 9, 2016

  1. The Assets menu in the menu bar does nothing, it shows all assets unfiltered for debugging reasons
  2. Yes, you can import new textures and models there
  3. What do you mean multiple times. Sure, you can import the same asset multiple times if you choose. But the asset manager loads the resource only once if you open the project.
  4. Yes, it shows only models. That's intended for now. Later on it will act as asset browser that shows all assets in a directory tree like a file explorer.

A few more notes:

  • You can apply textures to models independtly now (see the ModelComponent in the outline).
  • If you select a resource from the assets dialog, the resource is not loaded again. With the dialog you can only select a reference to that asset.
  • You can specify filters on the asset dialog, that's why some assets are somtimes not visible. E.g if you select a new texture for a model, the asset dialog will only show texture assets
  • It's not finished yet ;)

@krukhlis
Copy link
Contributor Author

Regarding 3)
So I can import multiple times the same texture. And in assets browser I will see multiple lines with this texture:
mundus-assets1
And I can use any of this as texture for my model. However, if save the project and reload Mundus --
I see the texture was loaded only once and I have only 1 entyry in assets browser:
mundus-assets2

Which is inconsistent with the original situation. :)

@mbrlabs
Copy link
Owner

mbrlabs commented Oct 10, 2016

Oh yes, that's a bug ;)
It's overriding the files when importing the asset for the second time. That's why they are gone after the restart. We need to check if there already exists a file with that name and if yes, add an extension to the filename. Or just forbid to import a new asset with the same name.
I'd prefer the second option, because it better reflects the organistion in folders.

I'll do that tomorrow.

@krukhlis
Copy link
Contributor Author

I also agree with the second option, cool!

@mbrlabs
Copy link
Owner

mbrlabs commented Oct 10, 2016

Alright, i fixed the bug by preventing the user to import multiple assets with the same name.

@mbrlabs mbrlabs closed this as completed Oct 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants