[LineChart] Added ability to specify x and y keys as functions #11
Conversation
| const xDomain = getExtent(data, (d) => d[xKey], xDomainProp); | ||
| const yDomain = getExtent(data, (d) => d[yKey], yDomainProp); | ||
| let xGetter: (record: Record) => X; | ||
| if (typeof xValueSelector === 'string') { |
There was a problem hiding this comment.
Would it be simpler to just support a function, or is it worth keeping support for strings?
There was a problem hiding this comment.
It doesn't add much complexity in code and perhaps someone may find it useful, so I'd keep it.
michaldudak
force-pushed
the
charts/xyAccessors
branch
from
0f84907
to
bba0cd1
Compare
|
Sorry @michaldudak I had to revert - it breaks the markers on the line charts due to the change of context variable name. There's also a demo using the old prop name. I should have actually tested it before committing. 😅 It would also be good to make this change for all the components for consistency, and add a docs demo of its use. |
|
Also d3 calls these types of functions "accessors" should we follow suit in the prop name, e.g. |
|
Good point. I'll change it. |
This gives the possibility to use a function to select data for x/y axes. The previous way (field selection by string) is still possible.