Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how internals work #7

Open
buddhike opened this issue Dec 16, 2017 · 2 comments
Open

Document how internals work #7

buddhike opened this issue Dec 16, 2017 · 2 comments
Labels

Comments

@buddhike
Copy link
Member

No description provided.

@bobzoller
Copy link

Something that tripped us up (but seems right) early on was that mbt ensures that your git checkout is clean (including untracked files) before each module build. I'm inferring then that it expects any artifacts to be stored outside the git checkout, and/or their paths included in a .gitignore file.

@buddhike
Copy link
Member Author

Dirty workspace check takes place only during the checkout phase. Not for each module build.
https://github.com/mbtproject/mbt/blob/master/lib/build.go#L103

Build is free to produce the artifacts inside repo during the build. However, if artifact path is not in .gitignore, next time you run mbt the dirty workspace check will kick-in.

Hope this helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants