Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order of OpSwitch Target Operands #28

Open
vili-1 opened this issue Apr 27, 2022 · 4 comments
Open

Order of OpSwitch Target Operands #28

vili-1 opened this issue Apr 27, 2022 · 4 comments

Comments

@vili-1
Copy link
Collaborator

vili-1 commented Apr 27, 2022

This example is from here https://github.com/afd/spirv-control-flow/blob/main/scraped-validator-tests/spv_1_0_FULLY_VALID_ValidateCFG_SwitchMultipleDefaultWithFallThroughGood.spv that we discussed in our meeting. I've annotated in the graph all the .als and .asm encodings. I think the problem is that first does not immediately precede third. Attached the .als and .asm files.

@afd @johnwickerson you mentioned in the meeting that we may not have considered occurences of default in our model - I can see that our model is in line with the suggested new rules, but please correct me if I'm missing something.

spv_1_0_FULLY_VALID_ValidateCFG_SwitchMultipleDefaultWithFallThroughGood

Archive.zip

@afd
Copy link
Member

afd commented Apr 27, 2022

Thanks! Will look. What I meant regarding not having considered default properly is that we didn't consider it fully in the new rules (I'm sure the model is in line with the rules, so perhaps the rules need a small tweak.)

@afd
Copy link
Member

afd commented May 11, 2022

I looked at this. I agree that it is invalid according to the suggested new rules, and I think that's fine - i.e., I think this example should indeed be regarded as invalid.

Let's open an issue so that we can discuss it with Alan.

@afd
Copy link
Member

afd commented May 11, 2022

@afd
Copy link
Member

afd commented Jun 23, 2022

It turned out that we did want this example to be valid, and we worked some more on the wording of the rules around switch statements to make it so.

Could discuss in paper under minor issues: an example of a conformance test suite informing our model.

@afd afd transferred this issue from another repository Oct 19, 2022
@afd afd added the modelling label Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants