add BerReader.readOID() #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
has a nice ring to it.
1. the octet var is being encoded, not an id var. 2. oid components >= 268435456 werent being encoded at all.
|
Super sorry this took so long to get to (holidays and all). It all looks good, although I think your typo is going to stick given the ordering of commits I see (ObjectDescritor). I'll just fix afterwards. |
|
Thanks David! It's out in npm@0.1.11, and I added you to the contributors field of the package.json file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i need readOID for parsing snmp packets. this passes superficial tests and has no impact on existing functionality.
this now includes fixes for writing OIDs with large (numerically) components.