Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A faster implementation for formatGuid function #133

Closed
wants to merge 5 commits into from

Conversation

mkononen
Copy link

Please see merge the changes in this commit to the main repository:
mkononen@5edb9f8

Pattern matching with preconstructed strings is (according to my measurements) about two times faster that using regular expressions.

@mkononen
Copy link
Author

My intention was not to make changes in the package.json. Sorry for the messy commit log.

@pfmooney
Copy link
Contributor

If you still want this merged, please clean it up into one commit and provide before/after benchmarks.

@pfmooney pfmooney closed this Apr 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants