Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export lighten and darken functions? #24

Open
EllaKaye opened this issue Dec 22, 2022 · 5 comments
Open

Export lighten and darken functions? #24

EllaKaye opened this issue Dec 22, 2022 · 5 comments
Labels
enhancement New feature or request
Milestone

Comments

@EllaKaye
Copy link

I notice that the code base has functions for lightening/darkening colour palettes and vectors but these are not exported. Any reason why not? They would be nice to have!

@mccarthy-m-g
Copy link
Owner

They would! I’m aiming to export these in v0.2.0 or v0.3.0.

I got a bit ahead of myself adding them to the code base, but didn’t want to export them yet because I’m still debating whether to wrap the relevant functions from the prismatic package (like it is now), or to write my own internals.

I do want to add colour manipulation functions that match a lot of what’s in prismatic (e.g., greyscale, saturate, etc.), so the dependency makes sense. But some of the functions there are missing options that might be nice.

For example, for lightening and darkening, prismatic only lets you change by a relative amount, but being able to supply an absolute amount too might be nice if you wanted all colours in a palette to have the same luminance. What do you think?

@mccarthy-m-g mccarthy-m-g added the enhancement New feature or request label Dec 22, 2022
@EllaKaye
Copy link
Author

Good that you have a road map for further development on the package - I'm excited to see where it goes!

Yes, having all colour the same luminance could be a nice option. Would take some thinking about though, given that not all combinations of Hue/Chroma/Luminance exist in HCL space (as I'm sure you know).

@mccarthy-m-g
Copy link
Owner

Me too! I can make a proper issue tracking features I’m thinking of if you’d like a public roadmap.

I’m actually learning all these colour science facts and problems as I go 😅 If I go with my own solution I’d probably base it off the formulas colorspace is using.

@EllaKaye
Copy link
Author

Learning as you go is the best way! That's what I did when I made a custom syntax highlighting theme then wrote a blog post about it.

I'd be intrigued to see a road map, but only if it doesn't put too much pressure on you 😅 Once I finish my thesis (mid-Feb) I'd also be happy to contribute, if you'd like/that would be useful/there's a feature I actually know how to implement!

@mccarthy-m-g
Copy link
Owner

Nice post! I like what you’ve done with your site too, looks great!

I’d be happy to have you as a contributor! I’ll make a simple road map with a task list tracking different issues; should make it easier to see what I need help with 😄

@mccarthy-m-g mccarthy-m-g added this to the Future milestone Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants