Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error reloading discarded tabs with illegal URLs #25

Closed
AntoineTurmel opened this issue Sep 11, 2018 · 3 comments
Closed

Error reloading discarded tabs with illegal URLs #25

AntoineTurmel opened this issue Sep 11, 2018 · 3 comments
Assignees
Labels

Comments

@AntoineTurmel
Copy link
Contributor

When I quit Firefox, I use the session restore feature... and I have noticed issues using Tab Image Saver:

  • Having "about:" tabs unloaded cause errors like this when I press the Tab Image Saver button:
    waitForTabs Error: "Illegal URL: about:newtab"
  • I tend to have lot of unloaded tabs when opening Firefox, it would be nice to have an option to just skip "unloaded" tabs instead of reloading them.

You can easily reproduce the first issue by:

  1. Opening a few tabs including about:newtab, about:preferences
  2. Enable restore previous session option from Firefox
  3. Quit Firefox with about: tabs opened
  4. Start Firefox
  5. Load a picture URL
  6. Press Tab Image Saver button.
  7. You will get the error in debugger

For now I was keeping version 1.3.0 because it would work flawless and quicker, but I figure I would help improve the add-on which has cool features and as I'm a webext developer as well.

@mcdamo mcdamo added the bug label Sep 12, 2018
@mcdamo
Copy link
Owner

mcdamo commented Sep 12, 2018

I think a filter on tab URLs is the best way to solve this error. Only tabs with http[s] or ftp[s] will be processed.

@mcdamo mcdamo self-assigned this Sep 12, 2018
@mcdamo
Copy link
Owner

mcdamo commented Sep 14, 2018

New release v2.3.0 should have resolved the issue of illegal URLs.

@AntoineTurmel
Copy link
Contributor Author

Thanks ! What about the second issue ?
I tend to have lot of unloaded tabs when opening Firefox, it would be nice to have an option to just skip "unloaded" tabs instead of reloading them. I think version 1.3.0 skip those tabs because it's way quicker !

@mcdamo mcdamo changed the title Issues concerning "unloaded" tabs Error reloading discarded tabs with illegal URLs Sep 17, 2018
@mcdamo mcdamo closed this as completed Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants