You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current implementation of hash_tree doesn't connect the returned objects together.
1 node = Node.find_by_id(1)
2 tree = node.hash_tree
3 tree.keys.first.children
Line 3 above will hit the database again, even though the children of node 1 have already been retrieved. It would be reasonable to expect line 2 to construct the tree so that calls to children or parent don't hit the database.
Is this by design, or would this be a desirable improvement?
The text was updated successfully, but these errors were encountered:
villesundberg
changed the title
Hash tree doesn't eager load childrenhash_tree doesn't eager load children
May 28, 2015
villesundberg
changed the title
hash_tree doesn't eager load children
hash_tree doesn't eager load children
May 28, 2015
An alternative (which would be useful) would be to have a hash_tree-like method that just returned the primary key IDs of the records in the tree, not the full records. This could then be used to pluck the actual items out of a collection that has been hashed by ID (e.g. using .index_by(&:id) on the end of an AR relation).
The current implementation of
hash_tree
doesn't connect the returned objects together.Line 3 above will hit the database again, even though the children of node 1 have already been retrieved. It would be reasonable to expect line 2 to construct the tree so that calls to
children
orparent
don't hit the database.Is this by design, or would this be a desirable improvement?
The text was updated successfully, but these errors were encountered: