Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Large Problem] FPSelectorHelper never get removed from eventListeners #570

Closed
mcenderdragon opened this issue May 30, 2019 · 3 comments
Closed

[Large Problem] FPSelectorHelper never get removed from eventListeners #570

mcenderdragon opened this issue May 30, 2019 · 3 comments
Labels
Bug Critical Solved in Dev it is solved in Dev - it just needs to be released

Comments

@mcenderdragon
Copy link
Owner

an FPSelectorHelper gets regostered to the world eventListeer but never removed this will pile up as the other reference (Map<Integer, WeakHashMap<IBlockSelector, FPSelectorHelper>>) is a weak reference is is gone so it ticks and is updated but is not need any more.
@mcenderdragon mcenderdragon added Bug Critical Solved in Dev it is solved in Dev - it just needs to be released labels May 30, 2019
@mcenderdragon
Copy link
Owner Author

This causes a large memory usage & high tick times

This was referenced Jun 1, 2019
Closed
Closed
@mcenderdragon mcenderdragon reopened this Jun 1, 2019
@mcenderdragon
Copy link
Owner Author

It seems like it got worse...

@mcenderdragon
Copy link
Owner Author

confirmed as fixed as of 26.4.82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Critical Solved in Dev it is solved in Dev - it just needs to be released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mcenderdragon