Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add log handler to be able to use a custom logger #5

Merged

Conversation

nicobritos
Copy link
Contributor

  • Add custom logger handler to use a custom Logger instead of printing to console.
  • Hide PusherChannelsPackageLogger from public API.
  • Fix logger tests not capturing what was being printed to console.
  • Remove logTest method as it is not needed anymore.

Copy link
Owner

@kerimamansaryyev kerimamansaryyev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed just an export to expose all structures from configs.dart for api library. Because it is used for development

@kerimamansaryyev kerimamansaryyev merged commit a1ab620 into kerimamansaryyev:master Aug 3, 2022
@kerimamansaryyev
Copy link
Owner

@nicobritos Thank you very much! I will mention this contribution in CHANGELOG.md

@nicobritos nicobritos deleted the feat-log-handler branch August 4, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants