Skip to content
This repository has been archived by the owner on Jul 6, 2020. It is now read-only.

Doesn't work on Android #43

Closed
MarcusCambio opened this issue Mar 16, 2020 · 4 comments
Closed

Doesn't work on Android #43

MarcusCambio opened this issue Mar 16, 2020 · 4 comments

Comments

@MarcusCambio
Copy link

Could not get this to work on Android, but then I saw that there is a PR that has been waiting to be merged for three weeks that did solve it: #42

How about merging it?

@mchome
Copy link
Owner

mchome commented Mar 16, 2020

Can you confirm that pr fix your issue?

@MarcusCambio
Copy link
Author

To be sure, I changed my dependency back to your master, and it actually works there too now, so no I can't confirm. Thanks anyway.

@janoschp
Copy link

janoschp commented May 26, 2020

@mchome I can confirm that the PR fixes this issue. I used the master version of your library and sometimes it works under Android but most fo the time it doesn't. I tested the PR version #42 and now setting the statusbar color always works. I suppose that in your master version the activity reference somehow gets lost and is therefore null, in the PR version this is fixed so it would be great if you could merge the PR.

@janoschp
Copy link

nvm it's actually buggy in the master version as well as the PR verion sigh

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants