Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default timing function causes the CLS score to drop significantly in Lighthouse #87

Open
meherhowji opened this issue Jun 5, 2021 · 0 comments

Comments

@meherhowji
Copy link

meherhowji commented Jun 5, 2021

While I was running lighthouse on my website, I noticed that not providing explicit timing function caused:

Avoid non-composited animations section to capture all the animations without timing function as Effect has unsupported timing parameters

Providing explicit data-sal-easing attribute, fixes this. I was wondering if there is a particular you see this getting solved, I can create a PR and help.


Reference:

Rendered CSS when using implicit easing function:

[data-sal] {
    transition-timing-function: ease;
    transition-timing-function: var(--sal-easing,ease); // this causes CLS issue in Lighthouse
}

Rendered CSS when using explicit easing function:

[data-sal][data-sal-easing=ease] {
    transition-timing-function: ease; // this doesn't get caught in CLS audit in Lighthouse
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant