Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: custom message type #3

Closed
kai-nashi opened this issue Jul 26, 2023 · 4 comments
Closed

Feat: custom message type #3

kai-nashi opened this issue Jul 26, 2023 · 4 comments

Comments

@kai-nashi
Copy link
Contributor

it would be good feature to allow defining custom message types to another modules can create non conflicts types. Then by your module separate them to tabs.

Example of module that can require that.
https://foundryvtt.com/packages/change-log

@kai-nashi
Copy link
Contributor Author

Hm... I read foundry API and discover game.messages objects. Unfortunately type is int, my idea is shit. BUT we can define chat sources by Message.speaker. For module above Message.speaker.alias is "Chat Log". I think your chat module has grate potential.

@Larkinabout
Copy link

Change Log module author here. This would be a great option and save me redoing what already exists with this module.

I'm happy to make changes to the Change Log module to support, such as adding a flag to the chat message. It looks like creating a chat tab with only the Other message type works, but a dedicated message type for when the Change Log module is also installed would be excellent.

If/When there's full support, I'll add this module as a recommended module in the Change Log readme and package page.

@kai-nashi
Copy link
Contributor Author

Pull request #5

@mclemente
Copy link
Owner

I will make some amends to it, like adding its own hook so modules don't need to check if the module is active and using game.tabbedchat instead of creating a window.tabbedchat just for the call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants