-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add actual but not expected items in the contains exactly matcher #106
Add actual but not expected items in the contains exactly matcher #106
Conversation
I think this might be a solution for #96. So at a glance this looks good, but let me try this out in a test project to make sure. |
fdb347e
to
dee4d6f
Compare
I'm still going to try to figure out what's going on here (I haven't exactly figured out how |
Hey @brunsa2, sorry for the delay in responding. The tests you changed in |
I'm not following. I'd expect |
Thoughts: put the extra actual values in order rather than at the end.
vs.
(I originally though the second was better but now like the first, as it currently stands, better again) |
1a23435
to
c5cf6fb
Compare
@mcmire CI is now failing before starting. I've tried twice. |
@brunsa2 Sorry about that. I just found out recently that a new release of RSpec broke the build. To add to this, Travis is switching over to a paid model, so CI builds take forever to run. I'm working on switching over to GitHub Actions and fixing the gem at the same time. Stay tuned! |
@brunsa2 Okay, the build is fixed and CI is now running against GitHub Actions instead of Travis. Try rebasing your branch against master! |
c5cf6fb
to
435ebdc
Compare
435ebdc
to
39772fd
Compare
Unless you're interested in changes from #106 (comment) I think this is ready, but there's a en extra "test" line waiting for status (not associated to a particular test config) that's holding off CI. |
@mcmire if you missed it |
1 similar comment
I apologize. I have been tending to other things. I will take a look at this tonight. |
I don't know why it's showing the build as not completed yet, because it is. Re: changing how the diff is presented, I don't know if I have an opinion on that right now. I can see both sides, but I feel like it's something that can be come back to. Anyway, I'll merge this. Sorry for the long wait and thank you! |
Thanks :) |
Contain exactly would previously not show any diff if there were things in the actual list that weren't in the expected list, but this is still a failure case.