Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usernames and folder names that match the ignore list break loading #6

Closed
gigaherz opened this issue Aug 9, 2021 · 3 comments
Closed

Comments

@gigaherz
Copy link

gigaherz commented Aug 9, 2021

The folder name C:\Users\rasmussen\AppData\Roaming\.minecraft contains the string "asm" in it, and so all libraries in the minecraft library repository are ignored. As a result, forge can't load.

username

The error:
error

A workaround is creating a new account without "asm" in the name, but this is highly inconvenient for most people.

@Rongmario
Copy link

Any explanation of why the string "asm" would induce this? Seems unreasonable.

@gigaherz
Copy link
Author

gigaherz commented Aug 9, 2021

It's due to the ignoreList written in the version json:

        "jvm": [
            "-DignoreList=bootstraplauncher,securejarhandler,asm-commons,asm-util,asm-analysis,asm-tree,asm,client-extra,fmlcore,javafmllanguage,mclanguage,forge-,${version_name}.jar",

The same would happen if your windows username was something like "forge-of-gods" since it would match the "forge-" ignore entry instead.

@McModLauncher McModLauncher deleted a comment from DaemonUmbra Aug 9, 2021
@LexManos
Copy link
Contributor

LexManos commented Aug 9, 2021

We've tried explicit version numbers, however modlauncher uses a wildcard and thus breaks that.
We need to make this a lot more robust, but still flexible.
Honestly we could try path.getFileName().startsWith() to be a bit more strict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants