Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileNotFoundException on first launch #30

Closed
JoJoDeveloping opened this issue Jun 12, 2019 · 1 comment
Closed

FileNotFoundException on first launch #30

JoJoDeveloping opened this issue Jun 12, 2019 · 1 comment

Comments

@JoJoDeveloping
Copy link

See 9438249#r33902825
Searching for additional locators on first launch fails since this is so early that the mods dir is not yet there because proper Forge has not done any initialisation.
A fix would be to either ignore the folder if missing, or to create it. IDK which is better so I haven't PR'd this yet.
@cpw
Copy link
Member

cpw commented Jul 15, 2019

Not a bug in ModLauncher, but in Forge, since forge provides the locator.

TheGlitch76 pushed a commit to PatchworkMC/YarnForge that referenced this issue Nov 23, 2020
@cpw
Fix error when ModsDiscoverer visits a non existent mods dir.
7eb9eaa 
Closes McModLauncher/modlauncher#30

Signed-off-by: cpw <cpw+github@weeksfamily.ca>

Tracking commit: MinecraftForge/MinecraftForge@9d82d82
TheGlitch76 pushed a commit to PatchworkMC/YarnForge that referenced this issue Nov 24, 2020
@cpw
Fix error when ModsDiscoverer visits a non existent mods dir.
01d6888 
Closes McModLauncher/modlauncher#30

Signed-off-by: cpw <cpw+github@weeksfamily.ca>

Tracking commit: MinecraftForge/MinecraftForge@9d82d82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cpw @JoJoDeveloping