Merge 9be3209 into 81e75ac

README.md

@@ -107,7 +107,7 @@ Options:
 * `connectTimeout`: the max number of milliseconds to wait for the CONNECT
   packet to arrive, defaults to `30000` milliseconds
 * `id`: id used to identify this broker instance in `$SYS` messages,
-  defaults to `shortid()`
+  defaults to `uuidv5()`
 * `preConnect`: function called when a valid CONNECT is received, see
   [instance.preConnect()](#preConnect)
 * `authenticate`: function used to authenticate clients, see
@@ -376,7 +376,7 @@ Events:
 <a name="clientid"></a>
 ### client#id
 
-The id of the client, as specified by the CONNECT packet.
+The id of the client, as specified by the CONNECT packet, defaults to 'aedes_' + shortid()
 
 -------------------------------------------------------
 <a name="clientclean"></a>

aedes.js

@@ -6,7 +6,7 @@ var util = require('util')
 var memory = require('aedes-persistence')
 var parallel = require('fastparallel')
 var series = require('fastseries')
-var shortid = require('shortid')
+var uuidv5 = require('uuid/v5')
 var Packet = require('aedes-packet')
 var bulk = require('bulk-write-stream')
 var reusify = require('reusify')
@@ -36,12 +36,13 @@ function Aedes (opts) {
 
   opts = Object.assign({}, defaultOptions, opts)
 
-  this.id = opts.id || shortid()
+  this.id = opts.id || uuidv5('https://github.com/mcollina/aedes', uuidv5.URL)
   this.counter = 0
   this.connectTimeout = opts.connectTimeout
   this.mq = opts.mq || mqemitter(opts)
   this.handle = function handle (conn) {
     conn.setMaxListeners(opts.concurrency * 2)
+    // create a new Client instance for a new connection
     // return, just to please standard
     return new Client(that, conn)
   }
@@ -244,8 +245,7 @@ Aedes.prototype.unsubscribe = function (topic, func, done) {
 Aedes.prototype.registerClient = function (client) {
   var that = this
   if (this.clients[client.id]) {
-    // moving out so we wait for this, so we don't
-    // unregister a good client
+    // [MQTT-3.1.4-2]
     this.clients[client.id].close(function closeClient () {
       that._finishRegisterClient(client)
     })