added error event for missing client Ids

moscajs · Jan 22, 2018 · c0fe6bd · c0fe6bd
1 parent 316bbb0
commit c0fe6bd
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/lib/client.js b/lib/client.js
@@ -151,7 +151,11 @@ function onError (err) {
   this.errored = true
   this.conn.removeAllListeners('error')
   this.conn.on('error', nop)
-  this.broker.emit('clientError', this, err)
+  if (this.id) {
+    this.broker.emit('clientError', this, err)
+  } else {
+    this.broker.emit('genericError', this, err)
+  }
   this.close()
 }
 

diff --git a/test/basic.js b/test/basic.js
@@ -321,6 +321,17 @@ test('closes', function (t) {
   })
 })
 
+test('testing other event', function (t) {
+
+  var broker = aedes()
+  var client = setup(broker)
+  broker.on('genericError', function (client, error) {
+    t.notOk(client.id, null)
+    t.end()
+  })
+  client.conn.emit('error', 'Connect not yet arrived')
+})
+
 test('connect without a clientId for MQTT 3.1.1', function (t) {
   var s = setup()